Skip to content

Conversation

@taylous
Copy link
Contributor

@taylous taylous commented Mar 9, 2025

summary

the description for the sync parameter of the onChange function was missing from the API documentation,
so I've added it.

upon reviewing the internal code, i found that it is invoked by the notify function.

specifically through: maybeNotify, resizeItem, measure

references

private notify = (sync: boolean) => {

this.notify(isScrolling)

this.notify(false)

this.notify(false)

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2025

⚠️ No Changeset found

Latest commit: 070d63d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Mar 9, 2025

View your CI Pipeline Execution ↗ for commit 070d63d.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 6s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-09 14:12:03 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 9, 2025

Open in Stackblitz

More templates

@tanstack/angular-virtual

npm i https://pkg.pr.new/@tanstack/angular-virtual@948

@tanstack/lit-virtual

npm i https://pkg.pr.new/@tanstack/lit-virtual@948

@tanstack/solid-virtual

npm i https://pkg.pr.new/@tanstack/solid-virtual@948

@tanstack/react-virtual

npm i https://pkg.pr.new/@tanstack/react-virtual@948

@tanstack/svelte-virtual

npm i https://pkg.pr.new/@tanstack/svelte-virtual@948

@tanstack/virtual-core

npm i https://pkg.pr.new/@tanstack/virtual-core@948

@tanstack/vue-virtual

npm i https://pkg.pr.new/@tanstack/vue-virtual@948

commit: 070d63d

@piecyk piecyk merged commit c879df4 into TanStack:main Mar 12, 2025
4 checks passed
@piecyk
Copy link
Collaborator

piecyk commented Mar 12, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants